Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style markdown code blocks #30

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Style markdown code blocks #30

merged 5 commits into from
Oct 3, 2023

Conversation

WebsByTodd
Copy link
Collaborator

Screenshot 2023-10-02 at 4 55 26 PM
  • Github Light theme chosen from the list of themes here
  • Can use CSS variables instead to create our own custom theme.
    :root {
    --shiki-color-text: #BBB;
    --shiki-color-background: #EEE;
    --shiki-token-constant: #ff8866;
    --shiki-token-string: #8855ff;
    --shiki-token-comment: #BBB;
    --shiki-token-keyword: #0099ff;
    --shiki-token-parameter: #33cccc;
    --shiki-token-function: #FFAA00;
    --shiki-token-string-expression: #8855ff;
    --shiki-token-punctuation: #BBB;
    --shiki-token-link: #0099ff;
    }
  • Java text blocks are breaking the syntax highlighting a bit (can be seen in the screenshot).

@WebsByTodd WebsByTodd added the docs Improvements or additions to documentation label Oct 2, 2023
@WebsByTodd
Copy link
Collaborator Author

This also fixes #28

@nedtwigg
Copy link
Member

nedtwigg commented Oct 3, 2023

Can we make the line height of the code blocks responsive? Ideally the height of the text and of the gap between lines would be the same in the code examples as in the body text above it.

Aside, the body text in this version looks a bit larger/fatter than in Framer. I think Framer's looks better, this is just a tad too heavy right now.

Base automatically changed from feat/mdx-to-html to main October 3, 2023 22:27
@WebsByTodd WebsByTodd mentioned this pull request Oct 3, 2023
@WebsByTodd
Copy link
Collaborator Author

Captured your code block feedback in #31 .

Aside, the body text in this version looks a bit larger/fatter than in Framer. I think Framer's looks better, this is just a tad too heavy right now.

In regards to this, I definitely see what you're talking about but I'm not sure of the root cause. The font, weights, sizes, and colors are identical in our app to the ones in framer. Then problem could be:

  • There is some CSS class (like border-style) that has an impact that I don't know about.
  • The actual loaded font glyphs are different. We're getting ours from the google CDN.

LMK if you think it's worth pursuing and I'll make an issue to track it and try to figure it out.

@WebsByTodd WebsByTodd merged commit beafe2e into main Oct 3, 2023
6 checks passed
@WebsByTodd WebsByTodd deleted the feat/code-blocks branch October 3, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants