Implement toBe(LITERAL), not just toBe_TODO()

[nedtwigg]

No description provided.

[nedtwigg]

So this test passes

selfie/selfie-runner-junit5/src/test/kotlin/com/diffplug/selfie/junit5/InlineIntTest.kt

Lines 34 to 40 in c04b9b4

	fun toBe_writeTODO() {
	ut_mirror().lineWith("expectSelfie").setContent(" expectSelfie(1234).toBe_TODO()")
	gradleReadSSFail()
	gradleWriteSS()
	ut_mirror().lineWith("expectSelfie").content() shouldBe " expectSelfie(1234).toBe(1234)"
	gradleReadSS()
	}

And this one fails

selfie/selfie-runner-junit5/src/test/kotlin/com/diffplug/selfie/junit5/InlineIntTest.kt

Lines 42 to 49 in c04b9b4

	@Test @Order(3)
	fun toBe_writeLiteral() {
	ut_mirror().lineWith("expectSelfie").setContent(" expectSelfie(7777).toBe(1234)")
	gradleReadSSFail()
	gradleWriteSS()
	ut_mirror().lineWith("expectSelfie").content() shouldBe " expectSelfie(7777).toBe(7777)"
	gradleReadSS()
	}

Because

• SourceFile::parseToBe_TODO is implemented, but SourceFile::parseToBe is not implemented yet

  • selfie/selfie-lib/src/commonMain/kotlin/com/diffplug/selfie/SourceFile.kt

    Lines 60 to 71 in c04b9b4

    	fun parseToBe_TODO(lineOneIndexed: Int): ToBeLiteral {
    	val lineContent = contentSlice.unixLine(lineOneIndexed)
    	val idx = lineContent.indexOf(".toBe_TODO()")
    	if (idx == -1) {
    	throw AssertionError(
    	"Expected to find `.toBe_TODO()` on line $lineOneIndexed, but there was only `${lineContent}`")
    	}
    	return ToBeLiteral(lineContent.subSequence(idx, idx + ".toBe_TODO()".length))
    	}
    	fun parseToBe(lineOneIndexed: Int): ToBeLiteral {
    	TODO("More complicated because we have to actually parse the literal")
    	}

• SourceFile.ToBeLiteral::parseLiteral is not implemented yet

  • selfie/selfie-lib/src/commonMain/kotlin/com/diffplug/selfie/SourceFile.kt

    Lines 51 to 58 in c04b9b4

    	/**
    	* Parses the current value of the value within `.toBe()`. This method should not be called on
    	* `toBe_TODO()`.
    	*/
    	fun <T : Any> parseLiteral(literalFormat: LiteralFormat<T>): T {
    	// this won't work, because we need to find the `.toBe` and parens
    	TODO("return literalFormat.parse(slice.toString())")
    	}

@jknack can you take a whack at finishing this PR sometime this week if you have time? Once you do, we should be able to run through the rest of the roadmap without much obstacle:

• Inline snapshot roadmap #48

[nedtwigg]

I just fixed up this branch with all the changes on main, but the tasks above are unchanged.

[nedtwigg]

Sorry @jknack, I deleted this branch on accident, it's still a needed WIP and the next piece of work I have for you if you end up having any more time in 2023.

[jknack]

@nedtwigg implemented handling of () while parsing .toBe

[nedtwigg]

Cases we need to handle:

.toBe("""
(((
"
(((
""")
// or
.toBe(
  "(((\n" +
  "\"\n" +
   "(((")

Cases we do not need to handle

.toBe(("a" + "b") + "c")

We should add support for these in future PRs, there are many hard cases, we should do the easy stuff first (""" literals) and then solve problems as they come.

[nedtwigg]

Huzzah!!

[nedtwigg]

Happy holidays @jknack, great to have you back! I will merge this, it's great! Next up you can burn through this list:

• Inline snapshot roadmap #48

For testing on many of them, I think we don't need the overhead of the SomeClass extends Harness / UT_SomeClass stuff, we should be able to just operate on plain-old strings.