Feature/ssh #20
Merged
Feature/ssh #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedtwigg
requested changes
Mar 29, 2021
spotless-changelog-lib/src/main/java/com/diffplug/spotless/changelog/GitActions.java
Outdated
Show resolved
Hide resolved
nedtwigg
requested changes
Mar 29, 2021
There was a problem hiding this comment.
Sorry I didn't think to suggest this earlier, but it jumped out at me as I looked at the new commits. There might be other SSH properties that users want to override in the future, and that will be easier if we have a consistent mapping.
I think the whole thing gets a bit simpler if we do this rename:
boolean sshDisableStrictHostKeyChecking = false;
String sshStrictHostKeyChecking = "yes";
That way we can automatically support any other String modes that SSH might have someday, and it's a consistent way to override whichever ssh config properties we add support for in the future.
spotless-changelog-lib/src/main/java/com/diffplug/spotless/changelog/GitActions.java
Outdated
Show resolved
Hide resolved
spotless-changelog-lib/src/main/java/com/diffplug/spotless/changelog/GitActions.java
Outdated
Show resolved
Hide resolved
spotless-changelog-lib/src/main/java/com/diffplug/spotless/changelog/GitCfg.java
Outdated
Show resolved
Hide resolved
...g-plugin-gradle/src/main/java/com/diffplug/spotless/changelog/gradle/ChangelogExtension.java
Show resolved
Hide resolved
...elog-plugin-gradle/src/main/java/com/diffplug/spotless/changelog/gradle/ChangelogPlugin.java
Outdated
Show resolved
Hide resolved
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this can resolve #19, but actually the StrictHostKeyChecking property is set to 'no'