Add support for scalafmt >= v0.7.0-RC1 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alexvetter, thanks for the PR! Would you kindly run |
|
Hi @jbduncan! Sorry, my bad. It should have been obvious to run |
|
No worries! Thanks for doing it so quickly. :) |
jbduncan
reviewed
Jul 11, 2017
|
|
||
| Object configured = fromHocon.invoke(null, configStr, fromHoconEmptyPath); | ||
| either = invokeNoArg(configured, "toEither"); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Hmm... is it possible to reduce the scope from Exception to a specific subclass?
|
|
Thanks @alexvetter! Unless @nedtwigg has anything else to say, this would probably be safe to merge in. @nedtwigg, do you have any thoughts? |
|
LGTM, thanks for the contribution! I'll be turning the release crank shortly. |
|
Released in 3.4.1 |
|
Thanks, that was fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scalafmt v0.7.0-RC1 the configuration API has been changed a little bit. This PR adds a pourman's switch (
try... catch...) to support both older and new versions.