Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to CTD 9.7. Include SLF4J log service. #389

Merged
merged 5 commits into from
Mar 31, 2019
Merged

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Mar 30, 2019

Upgrade to CDT 9.7.
Replaced Spotless CDT specific log service by the common SLF4J log service provided by spotless-eclipse-base.

@fvgh fvgh requested a review from nedtwigg March 30, 2019 15:34
@fvgh
Copy link
Member Author

fvgh commented Mar 30, 2019

@nedtwigg The release date in the CHANGES.md still contains a todo.
As described in #232, I checked the IncludeOrganizer. I actually had a prototype working. But seeing the dependencies on internal interfaces and the quite limited result, it was not worth the effort.
Hence I see currently no need for further changes on this spotless-eclipse-cdt.
Feel free to publish on Maven Central whenever you find time.

@nedtwigg
Copy link
Member

Seems that p2 repository was needed. I removed it, and I'm getting this error:

Could not resolve all files for configuration ':embeddedJars'.
> Could not find any matches for p2:org.eclipse.core.variables:+ as no versions of p2:org.eclipse.core.variables are available.
  Searched in the following locations:
      https://repo.maven.apache.org/maven2/p2/org.eclipse.core.variables/maven-metadata.xml
      https://repo.maven.apache.org/maven2/p2/org.eclipse.core.variables/
      https://jcenter.bintray.com/p2/org.eclipse.core.variables/maven-metadata.xml
      https://jcenter.bintray.com/p2/org.eclipse.core.variables/
      file:/Users/ntwigg/.m2/repository/p2/org.eclipse.core.variables/maven-metadata.xml
      file:/Users/ntwigg/.m2/repository/p2/org.eclipse.core.variables/
      file:/Users/ntwigg/Documents/dev/spotless/_ext/eclipse-cdt/build/p2asmaven/maven/p2/org.eclipse.core.variables/maven-metadata.xml
      file:/Users/ntwigg/Documents/dev/spotless/_ext/eclipse-cdt/build/p2asmaven/maven/p2/org.eclipse.core.variables/
  Required by:
      project :

I have some guesses for a fix, but I'll leave it for you @fvgh in case I'm missing some important context.

@fvgh
Copy link
Member Author

fvgh commented Mar 31, 2019

Sorry should have not committed in a hurry...

@nedtwigg nedtwigg merged commit 2e16d9c into master Mar 31, 2019
@nedtwigg nedtwigg deleted the eclipse-cdt-upgrade branch March 31, 2019 19:57
@nedtwigg
Copy link
Member

No worries, that's would code-review is for :) 9.7.0 published just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants