Refactor the public API of LicenseHeaderStep
#628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed a Builder to improve the readability of its many parameters and modes.
…code duplication).
…nse to elide it into the Builder, and instead hide the implementation as a private static class.
… plugin to respond to `ratchetFrom` in the most natural way.
nedtwigg
force-pushed
the
feat/license-api
branch
from
0dd86e8
to
1f8f170
Compare
|
Sorry for merging quickly without asking for feedback. Our Happy to revisit this even though it has already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had gotten very messy. It turns out that it's important to determine the year-handling lazily, because the sensible default is to depend on
ratchetFrom. To enable this, much of LicenseHeaderStep's guts had become public, and it had factory methods with way too many parameters.This PR refactors LicenseHeaderStep into an immutable builder pattern, which allows us to remove a lot of code from the gradle and maven plugins. It also offers a clean foundation for implementing features like #323.