Use -- to separate arguments from paths #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
commented
Apr 21, 2021
| @@ -335,7 +335,7 @@ private String setLicenseHeaderYearsFromGitHistory(String raw, File file) throws | |||
| } | |||
|
|
|||
| private static String parseYear(String cmd, File file) throws IOException { | |||
| String fullCmd = cmd + " " + file.getAbsolutePath(); | |||
| String fullCmd = cmd + " -- " + file.getAbsolutePath(); | |||
There was a problem hiding this comment.
Unsure if it's best to assume the cmd supports this, or whether it's better to hoist it up into the caller's strings for each command. Let me know...
Some paths have characters which make them ambiguous as to whether they're a path or argument
For example,
$ git log --follow --find-renames=40% --reverse a/b-c-d/e.txt
fatal: ambiguous argument 'a/b-c-d/e.txt': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
$ echo $?
128
compared to
$ git log --follow --find-renames=40% --reverse -- a/b-c-d/e.txt
$ echo $?
0
|
Thanks! Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some paths have characters which make them ambiguous as to whether they're a path or argument
For example,
compared to
Please add a commit that adds a bullet-point under the
-SNAPSHOTsection of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes: