-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support google-java-format's skip-reflowing-long-strings option #929
Support google-java-format's skip-reflowing-long-strings option #929
Conversation
Add configuration option to switch the option of the googleJavaFormat step. Default to not reflowing for backwards compatibility. Fixes diffplug#924
@tbroyer Thank you very much for your contribution! The only thing I'm questioning is, given how many parameters If we decide the answer is "no", then I wonder if it would be best for the Other than that, this PR LGTM, so well done and thanks again! |
I agree with @jbduncan that this would be easier to read if we had a builder. But because the list of parameters is so long, I think it's hopeless to worry about the parameter positions. I'm going to merge and release as-is, but a future refactor towards a builder would be welcome. My guess is that this will be the last feature anyone is able to add before they're forced to confront the builder mess. |
Released in |
Fwiw, tests aren't actually run with JDK 8 on CI ; causing a risk of regressions that won't be detected. Not sure how much you care about it. |
I think we test JDK 8, but windows-only. Agreed that it's a bit hidden. Lines 115 to 125 in 2b62d00
We get enough flaky dep-resolution problems that I don't want to trigger manual retries for every cell in the win/unix vs 8/11/latest matrix. |
Strange, this test should have failed for months if that was the case: ecca2b8 |
Add configuration option to switch the option of the googleJavaFormat step.
Default to not reflowing for backwards compatibility.
Fixes #924