Extract llvm_zone_t code into its own namespace. #398
Conversation
src/EXTZones.cpp
Outdated
| free(Zone); | ||
| } | ||
|
|
||
| // NOMERGE: dropped 'inline' on lots of these functions |
There was a problem hiding this comment.
lots of the functions here had inline specifiers that I've removed. I don't have a great reason for this, but I think less code is better. The right thing to do here would be to measure the impact of this somehow but I don't have any plans to do that.
| EXPORT void* llvm_zone_malloc(llvm_zone_t* zone, uint64_t size) | ||
| { | ||
| // NOMERGE: changed this | ||
| static std::unique_ptr<extemp::EXTMutex> alloc_mutex = []() { |
There was a problem hiding this comment.
This mutex was previously initialized somewhere else, but that meant it was polluting the global namespace a bit. I figure we can not do that and initialize it here where it's used instead.
I'm using unique_ptr here because MSVC didn't have the recursive_mutex(const recursive_mutex&) constructor, which is what this code tries to use if you write it without pointers.
|
Hey @nic-donaldson are you able to rebase this to the current master (55b47d7) and force push (which should update this PR)? That will re-run the tests (inc. on macOS 11) as well. |
nic-donaldson
force-pushed
the
llvm-zones
branch
from
767d485
to
589d9ea
Compare
yep, done! let's hope they pass :| |
Following a similar PR for
closure_address_table, this PR movesllvm_zone_tinto its own space.This PR is carved out from this larger diff: master...nic-donaldson:llvm-refactor#files_bucket which upgrades to LLVM 11. This is part of separating code that includes or links with LLVM code from code that doesn't.
I made a couple of small changes in some functions while doing this, I'll call out those spots with comments because it's hard to spot code that has moved + changed.