cleanup and dont use target blank

diggerhq · Jan 26, 2024 · ce94aef · ce94aef
1 parent 6b2cea1
commit ce94aef
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/backend/controllers/projects.go b/backend/controllers/projects.go
@@ -294,17 +294,16 @@ func SetJobStatusForProject(c *gin.Context) {
 		client, _, err := utils.GetGithubClient(&utils.DiggerGithubRealClientProvider{}, job.Batch.GithubInstallationId, job.Batch.RepoFullName)
 		if err != nil {
 			log.Printf("Error Creating github client: %v", err)
-			c.JSON(http.StatusInternalServerError, gin.H{"error": "Error Creating github client"})
-			return
-		}
-		_, workflowRunUrl, err := utils.GetWorkflowIdAndUrlFromDiggerJobId(client, job.Batch.RepoOwner, job.Batch.RepoName, job.DiggerJobID)
-		if err != nil {
-			log.Printf("Error getting workflow ID from job: %v", err)
 		} else {
-			job.WorkflowRunUrl = &workflowRunUrl
-			err = models.DB.UpdateDiggerJob(job)
+			_, workflowRunUrl, err := utils.GetWorkflowIdAndUrlFromDiggerJobId(client, job.Batch.RepoOwner, job.Batch.RepoName, job.DiggerJobID)
 			if err != nil {
-				log.Printf("Error updating digger job: %v", err)
+				log.Printf("Error getting workflow ID from job: %v", err)
+			} else {
+				job.WorkflowRunUrl = &workflowRunUrl
+				err = models.DB.UpdateDiggerJob(job)
+				if err != nil {
+					log.Printf("Error updating digger job: %v", err)
+				}
 			}
 		}
 	case "succeeded":

diff --git a/cli/pkg/digger/digger.go b/cli/pkg/digger/digger.go
@@ -164,7 +164,7 @@ func UpdateStatusComment(jobs []scheduler.SerializedJob, prNumber int, prService
 		}
 
 		message = message + fmt.Sprintf("<!-- PROJECTHOLDER %v -->\n", job.ProjectName)
-		message = message + fmt.Sprintf("%v **%v** <a href='%v' target='blank'>%v</a>%v\n", job.Status.ToEmoji(), jobSpec.ProjectName, *job.WorkflowRunUrl, job.Status.ToString(), job.ResourcesSummaryString())
+		message = message + fmt.Sprintf("%v **%v** <a href='%v'>%v</a>%v\n", job.Status.ToEmoji(), jobSpec.ProjectName, *job.WorkflowRunUrl, job.Status.ToString(), job.ResourcesSummaryString())
 		message = message + fmt.Sprintf("<!-- PROJECTHOLDEREND %v -->\n", job.ProjectName)
 	}