Fix: ensure that variables used for slack match the input variable name #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ri-roee
reviewed
Mar 20, 2024
Co-authored-by: Roee Landesman <155578531+ri-roee@users.noreply.github.com>
ri-roee
approved these changes
Mar 20, 2024
motatoes
approved these changes
Mar 20, 2024
ben-of-codecraft
pushed a commit
to ben-of-codecraft/digger
that referenced
this pull request
May 21, 2024
…me (diggerhq#1296) * update to be consistent with the input * Update action.yml Co-authored-by: Roee Landesman <155578531+ri-roee@users.noreply.github.com> --------- Co-authored-by: Roee Landesman <155578531+ri-roee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we need this change?
Introduced in #1239 a change went into the action to change the inputs for the digger portion of the action but didn't update the inputs to match. So this change ensures that inputs and usage are consistent. This prevents the slack_url from being a NULL always and causing drift detection to always fail out.
What effects does this change have?