Correctly pass project roles from orchestrator to cli #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ri-roee
approved these changes
Mar 20, 2024
motatoes
changed the title
motatoes
changed the title
ri-roee
approved these changes
Mar 21, 2024
UtpalJayNadiger
approved these changes
Mar 21, 2024
ben-of-codecraft
pushed a commit
to ben-of-codecraft/digger
that referenced
this pull request
May 21, 2024
* Correctly pass project roles from orchestrator to cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been not passing digger.yml project-level roles from backend to cli and therefore they were not working properly with orchestrator triggered jobs. We are now passing them and during unmarshal of the serialized json spec we set the right env provider in the job struct