Fix: Enable per project assumerole support in drift detection #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the multiple commits related to others I'd not planned on multiple fixes being needed and my develop still has changes that I don't want to close/reopen the pr related to. So will try and keep this clean |
|
Hey @JoshuaJackson-jobvite thanks for submitting this ! I had a quick look and I think that should resolve the issue. I haven't tested it myself but I think that's what is missing to get drift assumerole working. I'm merging and releasing Once again the e2e test fail for external contributors due to missing secret so ignoring for now |
motatoes
approved these changes
Apr 15, 2024
ben-of-codecraft
pushed a commit
to ben-of-codecraft/digger
that referenced
this pull request
May 21, 2024
…hq#1315) * add caching behaviors as an option to the action * fix: mixed if on the cache-save * initial attempt at fixing the assume * restore to upstream since develop has changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we need this change?
Drift detection currently does not take the properties from the digger.yml and do authentication changes to ensure that it can review the live resources for a given account. This attempts to fix that behavior to allow drift detection to work
What effects does this change have?
should fix #1133