Cache Go dependencies when building CLI #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sikha-root
force-pushed
the
feature/fix-go-build-caching
branch
5 times, most recently
from
08e7ddd
to
2ae9ae2
Compare
also pin setup-go version to cli's dependency file
sikha-root
force-pushed
the
feature/fix-go-build-caching
branch
from
2ae9ae2
to
eee9e7b
Compare
sikha-root
changed the title
|
Finally working at least in a way that's usable. This should close #1535 unless something different is desired. |
|
I'm assuming the CI failure here and in my other PR are just a result of external PRs not having access to a repository secret or something. Should be resolved separately I guess. |
motatoes
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables dependency caching of the Digger CLI binary being built in a deploy when not using version tags (I'm using hashes for immutability). Since it seems I can't use
hashFilesfor files outside of the workspace of the Terraform code repo running the action we copy that file to one that shouldn't collide with any source files so that we can ensure the cache key is sufficiently unique (maybe not unique enough? not sure).I'm reusing the
cache-dependenciesinput here because of the name and the description provided indicating that it should probably cover this instead of just Terraform providers, and people turning that on likely want this too.Also pins the go version used by setup-go to the one in
cli's dependency file.