Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop incompatible PHP versions #65

Closed
wants to merge 5 commits into from

Conversation

szepeviktor
Copy link
Contributor

symfony/filesystem 3.0.x-dev requires php >=5.5.9

> symfony/filesystem 3.0.x-dev requires php >=5.5.9
Still not fixed `ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/run/mysql-5.6/mysqld.sock' (2)`
@szepeviktor
Copy link
Contributor Author

@diggy Have you seen this one?

@diggy
Copy link
Owner

diggy commented Jun 10, 2017

@szepeviktor Yes, in fact I'd like to improve support rather than drop it, cf. Chouby's effort with Polylang proper to reflect WP's min req. Could you explain exactly why WP-CLI core is able to run on 5.3 and this package would require 5.5.9 or higher (apart from the fact that it's currently using traits, incompatible syntax etc)?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jun 10, 2017

Now I see that wp-cli has an alternative dependency version
https://github.com/wp-cli/wp-cli/blob/master/composer.json#L33

Why Travis is trying with the higher, incompatible one on PHP 5.3/5.4???
https://travis-ci.org/diggy/polylang-cli/jobs/241538140#L193

@szepeviktor
Copy link
Contributor Author

I've started an UpCould instance with Debian 7 with PHP 5.4:

root@ppp:~# composer require wp-cli/wp-cli:dev-master
Do not run Composer as root/super user! See https://getcomposer.org/root for details
./composer.json has been created
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 50 installs, 0 updates, 0 removals
  - Installing wp-cli/autoload-splitter (v0.1.3): Downloading (100%)
  - Installing wp-cli/php-cli-tools (v0.11.2): Downloading (100%)
  - Installing wp-cli/mustangostang-spyc (0.6.3): Downloading (100%)
  - Installing composer/semver (1.4.2): Downloading (100%)
  - Installing mustache/mustache (v2.11.1): Downloading (100%)
  - Installing ramsey/array_column (1.1.3): Downloading (100%)
  - Installing rmccue/requests (v1.7.0): Downloading (100%)
  - Installing symfony/filesystem (v2.8.22): Downloading (100%)

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jun 10, 2017

Maybe composer is badly caching on Travis?
https://travis-ci.org/diggy/polylang-cli/jobs/241538140#L179

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jun 10, 2017

Or old composer version is forced?
https://travis-ci.org/diggy/polylang-cli/jobs/241538140#L155

But

Composer requires PHP 5.3.2+ to run.

https://getcomposer.org/doc/00-intro.md#system-requirements

@szepeviktor
Copy link
Contributor Author

@szepeviktor
Copy link
Contributor Author

@diggy
Copy link
Owner

diggy commented Jun 10, 2017

@szepeviktor my composer-fu is rather limited, what about this:

diggy added a commit that referenced this pull request Feb 15, 2018
@diggy diggy closed this in #117 Feb 15, 2018
@szepeviktor szepeviktor deleted the patch-1 branch February 15, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants