Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

Out of Date Docs. #70

Closed
abroccoli opened this issue Apr 9, 2018 · 5 comments · Fixed by digiaonline/react-foundation-docs#10
Closed

Out of Date Docs. #70

abroccoli opened this issue Apr 9, 2018 · 5 comments · Fixed by digiaonline/react-foundation-docs#10
Assignees

Comments

@abroccoli
Copy link

foundation-sites@6.4.4
react-foundation@0.9.4 

Hey all,

New installs of foundation-sites no longer have out of the box support for the float-grid system used by the Row and Column components. It has to be specifically enabled. This will no longer work for folks like myself making fresh codebases with the latest versions of foundation-sites and react-foundation:

<Row className="display">
   <Column small={2} large={4}>4 columns</Column>
   <Column small={4} large={4}>4 columns</Column>
   <Column small={6} large={4}>4 columns</Column>
</Row>

Digging through the commits for react-foundation, I saw that all the work to use the XY-grid system has already been done, and this works perfectly:

<Grid className="display">
     <Cell small={2} large={4}>4 columns</Cell>
     <Cell small={4} large={4}>4 columns</Cell>
     <Cell small={6} large={4}>4 columns</Cell>
</Grid>

Updating the docs to reflect this would save a lot of headaches for foundation newbies like myself.

Appreciate all the work you've put into this!

@hugovk
Copy link
Contributor

hugovk commented Apr 10, 2018

@abroccoli Thank you for the report, please could you submit a pull request to https://github.com/digiaonline/react-foundation-docs? Thanks!

@JoshuaJWayne
Copy link

JoshuaJWayne commented Oct 17, 2018

I would also like to request an update to the Documentation. I am relatively new to working with ReactJs and have been looking for a way Foundation 6 + React. Your Components seem like the perfect pairing to do this however I am unable to use them as the instruction is not clear to a newer react developer.

import React from 'react-foundation' ;
... use components <--- this is unclear

I was able to get some of the components working in my project by importing them individually.
example:
import {Button, Colors, Sizes, Badge, Cell, Grid, GridContainer} from "react-foundation";
then they work just fine but this is not clearly documented and I feel that there may be a easier way to work with your components.

Thank you for all the work that was put into this project.

@joebentaylor
Copy link

joebentaylor commented Feb 19, 2019

@JoshuaJWayne isnt it supposed to be:
import Foundation from 'react-foundation';
not:
import React from 'react-foundation';

@zoe-gonzales
Copy link
Contributor

Hi, I’ve run into some of the same issues above being new to Foundation with React. This thread has helped a lot. Is anyone currently working on these updates? If not, could I please work on them?

@hugovk
Copy link
Contributor

hugovk commented May 7, 2019

@zoe-gonzales No-one is currently working on this, a PR would be welcome. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants