Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/new UI edit observation attachment #372

Merged
merged 48 commits into from
May 28, 2024

Conversation

bohdanprog
Copy link
Collaborator

@bohdanprog bohdanprog commented May 21, 2024

Important

Have to merge PRs #356 and #335 before current PR

Closes #357

How it looks now:

After
Screenshot 2024-05-22 at 08 44 25

@bohdanprog bohdanprog self-assigned this May 21, 2024
@bohdanprog bohdanprog requested review from achou11 and ErikSin and removed request for achou11 May 21, 2024 12:35
@bohdanprog bohdanprog changed the base branch from main to feat/redesign-edit-observation May 21, 2024 12:36
@bohdanprog bohdanprog requested a review from achou11 May 21, 2024 12:42
Base automatically changed from feat/redesign-edit-observation to main May 21, 2024 20:10
@ErikSin ErikSin removed the request for review from achou11 May 21, 2024 21:41
Copy link
Contributor

@EvanHahn EvanHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks but overall looks good.

src/frontend/sharedComponents/Thumbnail/index.tsx Outdated Show resolved Hide resolved
src/frontend/sharedComponents/Thumbnail/Thumbnail.tsx Outdated Show resolved Hide resolved
@bohdanprog bohdanprog requested a review from EvanHahn May 27, 2024 19:18
@bohdanprog bohdanprog merged commit e2f368b into main May 28, 2024
3 checks passed
@bohdanprog bohdanprog deleted the feat/new-ui-edit-observation-atachment branch May 28, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New / Edit Observation - With attachments
3 participants