Meged Most active branches #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for image overlays.
…-stream-mime remove need for css-img-datauri-stream
Fix crash on side by side control remove
Add possibility to swap images
# Conflicts: # index.js # leaflet-side-by-side.js # leaflet-side-by-side.min.js # package-lock.json # package.json
Figured out why the errors were happening in _updateLayerClip its when the layer is removed from the map it cant update clip.. so i added a check for the layer being on the map before clipping.
|
If anyone has issues with this let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged the 2 most active branches in an atempt to make the most up to day version of this If anyone has other improvements feel free to create a pull to my repo otherwise this might help someone else.
this includes this #23
as well as s22s updates https://github.com/s22s/leaflet-side-by-side