single-stream replication & discovery fixes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
|
|
||
| ### sync.on('target', target) | ||
|
|
||
| Emitted when a new wifi target is discovered. | ||
|
|
||
| ### var ev = sync.syncToTarget(target) |
There was a problem hiding this comment.
- what do you think about calling this
sync.start(target)? - would it be possible to implement a
sync.stop(target)to cancel the sync?
There was a problem hiding this comment.
(by the way, not saying to implement sync.stop here, but just wondering if it would be possible with current arch)
There was a problem hiding this comment.
Good Q! I think it's safe to interrupt the sync stream; maybe just doing stream.destroy() would be OK?
There was a problem hiding this comment.
I'm good with the name change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.