Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update TypeScript to v5 #123

Merged
merged 1 commit into from
Feb 26, 2024
Merged

chore: update TypeScript to v5 #123

merged 1 commit into from
Feb 26, 2024

Conversation

EvanHahn
Copy link
Contributor

This upgrades TypeScript from v4.7.4 to v5.3.3. This required a small number of type-related changes: updating the @typescript-eslint dependencies, updating the dependencies for @types/eventsource, and fixing a small type error in the import worker.

The dist/ folder looks very similar after this, though (1) source map files changed (2) TypeScript now adds the declare keyword in .d.ts files, such as:

-export type GlyphsResult = {
+export declare type GlyphsResult = {

There were no changes to any compiled .js files after this change.

This upgrades TypeScript from v4.7.4 to v5.3.3. This required a small
number of type-related changes: updating the `@typescript-eslint`
dependencies, updating the dependencies for `@types/eventsource`, and
fixing a small type error in the import worker.

The `dist/` folder looks very similar after this, though (1) source map
files changed (2) TypeScript now adds the `declare` keyword in `.d.ts`
files, such as:

```diff
-export type GlyphsResult = {
+export declare type GlyphsResult = {
```

There were no changes to any compiled `.js` files after this change.
@EvanHahn EvanHahn merged commit 79d29d3 into master Feb 26, 2024
3 checks passed
@EvanHahn EvanHahn deleted the update-typescript-to-v5 branch February 26, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants