Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling an edit should show "discard edits" not "discard observation" #381

Closed
gmaclennan opened this issue Apr 20, 2020 · 0 comments · Fixed by #472 or #532
Closed

Cancelling an edit should show "discard edits" not "discard observation" #381

gmaclennan opened this issue Apr 20, 2020 · 0 comments · Fixed by #472 or #532
Labels
Milestone

Comments

@gmaclennan
Copy link
Member

Currently when you edit an observation, and then press the go back button rather than the save button, the message says "discard observation" / descartar... when really it should say discard edits as you do not delete the whole observation by not saving changes.

@gmaclennan gmaclennan added the bug label Apr 20, 2020
@gmaclennan gmaclennan added this to the release/v2.2.0 milestone Apr 20, 2020
gmaclennan added a commit that referenced this issue Sep 29, 2020
…dit (#472)

* chore: use react-native touchables in tests (RNGH = flaky tests)

It seems like in e2e tests the detox tap() is too fast for RNGH to
register, causing button taps to fail:
software-mansion/react-native-reanimated#596

* fix: Show "discard edits" not "discard observation" when cancelling edit

fixes #381

* add tests

* fix crash in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant