Tleon/sx support xbpl 315 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using 'set_parameter' method of an XBee object, the check was not being performed. This commit moves the check to the AbstractXBeeDevice class so it is always performed, and the XBee info parameters NI or MY update its value for the corresponding node. Related to commit 81716a9 Signed-off-by: Tatiana Leon <tatiana.leon@digi.com>
This also includes to set the protocol depending on the value of the BR (RF data rate) parameter: if '0' to DigiPoint (P2MP, point to multipoint), otherwise DigiMesh. https://jira.digi.com/browse/XBPL-315 Signed-off-by: Tatiana Leon <tatiana.leon@digi.com>
When a non-deep discovery is launched, all discovered nodes are added to a list. But this list is never emptied that is clearly a memory leak. This commit clears this list before starting a new discovery process and once the discovery of a list of devices finishes. #172 Signed-off-by: Tatiana Leon <tatiana.leon@digi.com>
tatianaleon
requested review from
jviguera,
diescalo,
daescalona,
rubenmoral,
ihermida and
hgonzaleDigi
jviguera
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.digi.com/browse/XBPL-315
#172