Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth v2 provisional classes #22

Merged
merged 4 commits into from
Nov 23, 2022
Merged

Auth v2 provisional classes #22

merged 4 commits into from
Nov 23, 2022

Conversation

tomcrane
Copy link
Contributor

New set of classes to allow Auth2 in IIIF resources.

Includes serialisation tests to make sure they can be used together.

Also added a test to demonstrate Image1 and Image2 together.

One interesting nugget from this is the probe service for and location properties, which can point to Image Services or Content Resources. The type of this property had to be JsonLdBase - there's no more specialised common base class.

I think this is OK though.

Copy link
Member

@donaldgray donaldgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomcrane tomcrane merged commit fd52c57 into main Nov 23, 2022
@tomcrane tomcrane deleted the auth-v2 branch November 23, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants