Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize as a npm package #65

Closed
hsiaoyi0504 opened this issue May 17, 2018 · 6 comments
Closed

Organize as a npm package #65

hsiaoyi0504 opened this issue May 17, 2018 · 6 comments

Comments

@hsiaoyi0504
Copy link

It would be good to make this as a npm package and can be installed by npm. This change will let user don't need to include a copy into their repo.

@tdlowden
Copy link
Contributor

hi! can you elaborate? are you referring to the https://github.com/18F/analytics.usa.gov/ repo?

@tdlowden
Copy link
Contributor

Or do you mean for DAP <script> implementation?

@hsiaoyi0504 hsiaoyi0504 changed the title Organize a npm package Organize as a npm package May 17, 2018
@hsiaoyi0504
Copy link
Author

hsiaoyi0504 commented May 17, 2018

Hi @tdlowden, I think the suggestion (feature request) is for this repo.
Make this repo as a npm package enable users (built project based on it) to install the script through npm install and keep track the version of it through package.json https://docs.npmjs.com/files/package.json (for version management purpose).

@hsiaoyi0504
Copy link
Author

hsiaoyi0504 commented May 17, 2018

For example, we have a project using the Universal-Federated-Analytics.js, but we will combine this file together with other .js files (also minify it together), and basically, we don't modify the original script, so we don't have a copy inside the repo, but collecting this script during building our project.

@eddietejeda
Copy link
Contributor

eddietejeda commented Sep 11, 2018

We've begun taking the steps to turn this into npm package in this pull request: #68

I think a few other clean up steps are required, but afterward, we can see if we can publish to npm.

@hsiaoyi0504
Copy link
Author

hsiaoyi0504 commented Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants