Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include DAP government code into app-layout.js #246

Closed
deming7h777 opened this issue Oct 16, 2018 · 2 comments
Closed

Include DAP government code into app-layout.js #246

deming7h777 opened this issue Oct 16, 2018 · 2 comments
Assignees
@deming7h777

Comments

@deming7h777
Copy link
Contributor

Currently, we include the DAP government code into our template

https://github.com/NAL-i5K/NAL-genomics-workspace/blob/5b6e56257be1094e0c70ce8c2e45cda41db26bef/app/templates/app/layout.html#L19

but based on digital-analytics-program/gov-wide-code#65, we can now track this dependency by package.json and include it into app-layout.js generated by django-pipeline

Related links:

https://stackoverflow.com/questions/39732397/install-specific-branch-from-github-using-npm
https://stackoverflow.com/questions/14187956/npm-install-from-git-in-a-specific-version
@deming7h777 deming7h777 self-assigned this Oct 16, 2018
@hsiaoyi0504
Copy link
Member

This issue should be opened in NAL-genomics-workspace. Not this one.

@deming7h777 deming7h777 mentioned this issue Oct 17, 2018
Closed
@deming7h777
Copy link
Contributor Author

Issue moved to NAL-i5K/NAL-genomics-workspace #13 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deming7h777 deming7h777

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hsiaoyi0504 @deming7h777