Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup exclusions in compatibility tests for test tool #5851

Closed
cocreature opened this issue May 5, 2020 · 0 comments · Fixed by #6094
Closed

Cleanup exclusions in compatibility tests for test tool #5851

cocreature opened this issue May 5, 2020 · 0 comments · Fixed by #6094
Assignees
@cocreature
Milestone
Release and Compa...

Comments

@cocreature
Copy link
Contributor

The dictionary that stores exclusions is getting increasingly unmaintainable

daml/compatibility/bazel_tools/testing.bzl

Line 16 in 150e036

excluded_test_tool_tests = {

We could probably simplify it significantly if we can exclude tests for a range of versions.
@cocreature cocreature self-assigned this May 25, 2020
cocreature added a commit that referenced this issue May 25, 2020
@cocreature
Support version ranges in test tool exclusions
dc0eef4 
This cleans up the map of exclusions for the ledger-api-test-tool part
of the compat tests. For now, you can only use ranges for the inner
map. In principle we could also add it to the outer map but I’ll leave
that for a separate PR.

I’ve also run the script to update versions so this includes the
latest two snapshots.

fixes #5851

changelog_begin
changelog_end
@cocreature cocreature mentioned this issue May 25, 2020
Merged
6 tasks
cocreature added a commit that referenced this issue May 25, 2020
@cocreature
Support version ranges in test tool exclusions
69480ed 
This cleans up the map of exclusions for the ledger-api-test-tool part
of the compat tests. For now, you can only use ranges for the inner
map. In principle we could also add it to the outer map but I’ll leave
that for a separate PR.

I’ve also run the script to update versions so this includes the
latest two snapshots.

fixes #5851

changelog_begin
changelog_end
cocreature added a commit that referenced this issue May 26, 2020
@cocreature
Support version ranges in test tool exclusions
1e4b4f7 
This cleans up the map of exclusions for the ledger-api-test-tool part
of the compat tests. For now, you can only use ranges for the inner
map. In principle we could also add it to the outer map but I’ll leave
that for a separate PR.

I’ve also run the script to update versions so this includes the
latest two snapshots.

fixes #5851

changelog_begin
changelog_end
cocreature added a commit that referenced this issue May 26, 2020
@cocreature
Support version ranges in test tool exclusions (#6094)
e86fbed 
* Support version ranges in test tool exclusions

This cleans up the map of exclusions for the ledger-api-test-tool part
of the compat tests. For now, you can only use ranges for the inner
map. In principle we could also add it to the outer map but I’ll leave
that for a separate PR.

I’ve also run the script to update versions so this includes the
latest two snapshots.

fixes #5851

changelog_begin
changelog_end

* Address review comments

changelog_begin
changelog_end

* buildifier

changelog_begin
changelog_end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cocreature cocreature

Labels
None yet
Projects
None yet
Milestone
Release and Compatibility Testing
Development

Successfully merging a pull request may close this issue.

Support version ranges in test tool exclusions digital-asset/daml
1 participant
@cocreature