decide whether we want to accept empty submissions / produce empty transactions

[bitonic]

@gerolf-da noted that right now we accept empty submissions, or more generally commands that generate empty transactions. this is somewhat odd since it lets people spam the ledger without really adding anything to it.

it is not a security issue since the submissions would still be authorized, but it would probably be a good idea to just reject such empty submissions, or maybe accept them but produce no transaction for them.

cc @meiersi-da @gaboraranyossy-da @dajmaki

[gabor-aranyossy]

I am fine with rejecting it. I recall this was under consideration during the ledger api design, but I don't remember the argument defending it. @mziolekda might have it documented somewhere

[meiersi-da]

Reject and document would be my recommendation to avoid this edge-case wrt ledger resource usage.

…

On Thu, Apr 18, 2019 at 9:50 AM Gabor Aranyossy ***@***.***> wrote: I am fine with rejecting it. I recall this was under consideration during the ledger api design, but I don't remember the argument defending it. @mziolekda <https://github.com/mziolekda> might have it documented somewhere — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#592 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADJA36F2DKCFEK577KVD7VLPRAR4ZANCNFSM4HG2PBEA> .

-- Dr. Simon Meier Director of Engineering c: +41 79 346 24 10 <+41%2079%20346%2024%2010> e: simon@digitalasset.com  Digital Asset (Switzerland) GmbH Thurgauerstrasse 40, 8050 Zurich, Switzerland digitalasset.com <http://www.digitalasset.com/>

-- This message, and any attachments, is for the intended recipient(s) only, may contain information that is privileged, confidential and/or proprietary and subject to important terms and conditions available at  http://www.digitalasset.com/emaildisclaimer.html <http://www.digitalasset.com/emaildisclaimer.html>. If you are not the intended recipient, please delete this message.

[mziolekda]

I am fine with rejecting empty submissions. I don't find anything with regards to that in my notes. So if it was discussed at the time, as Gabor suggests, it must have been such low priority, that I didn't bother writing it down anywhere.