Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow empty command submission #3270

Merged
merged 11 commits into from Oct 31, 2019
Merged

Disallow empty command submission #3270

merged 11 commits into from Oct 31, 2019

Conversation

stefanobaghino-da
Copy link
Contributor

Fixes #592

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

gerolf-da
gerolf-da reviewed Oct 29, 2019
View reviewed changes
Copy link
Contributor

@gerolf-da gerolf-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be surprised that this passes as is, because we have many old-style integration tests that never send actual individual commands (see MockMessages).

@stefanobaghino-da
Copy link
Contributor Author

I'd be surprised that this passes as is, because we have many old-style integration tests that never send actual individual commands (see MockMessages).

Indeed. I changed all such tests with additional commits. Let me know if this LGTY. 🙂

@stefanobaghino-da
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@gerolf-da gerolf-da merged commit d9ae487 into master Oct 31, 2019
@gerolf-da gerolf-da deleted the 592 branch October 31, 2019 07:38
@gerolf-da gerolf-da added the component/ledger Sandbox and Ledger API label Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerolf-da gerolf-da gerolf-da approved these changes

@rautenrieth-da rautenrieth-da Awaiting requested review from rautenrieth-da

Assignees
No one assigned
Labels
component/ledger Sandbox and Ledger API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

decide whether we want to accept empty submissions / produce empty transactions
2 participants
@stefanobaghino-da @gerolf-da