-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extractor: subscribe to multiple parties #1360
Conversation
…ractor-multiple-parties
@S11001001 I will give it a more thorough review on Tuesday... but so far I don't see changes in the
I would also make it plural: |
@leo-da I think we should keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please add a tests that ensures we can use parties with spaces in them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
@S11001001 @bitonic I don't think it will work with multiple |
actually it has to be
|
@bitonic Not sure how these are related; parties are comma-separated in this PR, not space-separated. |
@@ -279,7 +279,7 @@ object ConfigParser { | |||
cliParams.ledgerPort, | |||
from, | |||
to, | |||
cliParams.party, | |||
ExtractorConfig.parties(cliParams.party), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leo-da This is the splitting you were looking for; I have a weak preference for doing as little parsing into CliParams
as possible, but do you want me to add moar type safety for CliParams
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nah, it is fine... but my main concern was documentation, the help screen. Plus the thing that @bitonic wanted you need unbounded
option configuration, to support multiple party options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docced in 1c2cb89
@S11001001 I think @bitonic wants to support spaces in the Party names like:
|
@leo-da I understand that, but as you noted |
@S11001001 I find spaces + commas quite awkward. in any case, this is ok for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The extractor
--party
option may now specify multiple parties, separated by commas; e.g. instead of--party Bob
you can say--party Bob,Bar,Baz
and get the contracts for all three parties in the database.Fixes #1353.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.