Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colon (:) to party literal #1467

Merged
merged 1 commit into from Jun 4, 2019
Merged

Add colon (:) to party literal #1467

merged 1 commit into from Jun 4, 2019

Conversation

remyhaemmerle-da
Copy link
Collaborator

In this PR we add colon to party literal. We also do some minor cleanup in the specification.

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Copy link
Contributor

@gabor-aranyossy gabor-aranyossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as @remyhaemmerle-da confirms that @bitonic is aware of this change.

@hurryabit
Copy link
Contributor

Are we retroactively changing the DAML-LF spec here?

@mergify mergify bot merged commit e115c39 into master Jun 4, 2019
@mergify mergify bot deleted the spec-cleanup branch June 4, 2019 15:50
remyhaemmerle-da added a commit that referenced this pull request Jun 6, 2019
remyhaemmerle-da added a commit that referenced this pull request Jun 6, 2019
remyhaemmerle-da added a commit that referenced this pull request Jun 6, 2019
mergify bot pushed a commit that referenced this pull request Jun 6, 2019
* add forgotten changes to the changelog
about fixed issue #398 and PR #1467

* Address Beth's comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants