Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colon (:) to party literal #1467

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
5 participants
@remyhaemmerle-da
Copy link
Contributor

commented May 31, 2019

In this PR we add colon to party literal. We also do some minor cleanup in the specification.

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@gaboraranyossy-da
Copy link
Contributor

left a comment

Approving as @remyhaemmerle-da confirms that @bitonic is aware of this change.

@remyhaemmerle-da remyhaemmerle-da force-pushed the spec-cleanup branch 2 times, most recently from 0c60c69 to 572031f May 31, 2019

@remyhaemmerle-da remyhaemmerle-da added this to the Maintenance milestone May 31, 2019

@remyhaemmerle-da remyhaemmerle-da requested review from bitonic and S11001001 May 31, 2019

@hurryabit

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

Are we retroactively changing the DAML-LF spec here?

@remyhaemmerle-da remyhaemmerle-da force-pushed the spec-cleanup branch from 572031f to ea895bb Jun 3, 2019

@digital-asset digital-asset deleted a comment from remyhaemmerle-da Jun 3, 2019

@remyhaemmerle-da remyhaemmerle-da force-pushed the spec-cleanup branch from ea895bb to 382475d Jun 4, 2019

@remyhaemmerle-da remyhaemmerle-da requested a review from leo-da as a code owner Jun 4, 2019

@bitonic

bitonic approved these changes Jun 4, 2019

@remyhaemmerle-da remyhaemmerle-da force-pushed the spec-cleanup branch from 382475d to 5028c2f Jun 4, 2019

@cocreature cocreature force-pushed the spec-cleanup branch from 5028c2f to 6339bc3 Jun 4, 2019

@cocreature cocreature force-pushed the spec-cleanup branch from 6339bc3 to 199e3c2 Jun 4, 2019

@mergify mergify bot merged commit e115c39 into master Jun 4, 2019

7 checks passed

Summary 1 rule matches and 1 potential rule
Details
digital-asset.daml Build #20190604.108 succeeded
Details
digital-asset.daml (Linux) Linux succeeded
Details
digital-asset.daml (Windows) Windows succeeded
Details
digital-asset.daml (macOS) macOS succeeded
Details
digital-asset.daml (perf) perf succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@mergify mergify bot deleted the spec-cleanup branch Jun 4, 2019

remyhaemmerle-da added a commit that referenced this pull request Jun 6, 2019

add forgotten changes to the changelog
about fixed issue #398 and PR #1467

@remyhaemmerle-da remyhaemmerle-da referenced this pull request Jun 6, 2019

Merged

add forgotten changes to the changelog #1539

4 of 5 tasks complete

remyhaemmerle-da added a commit that referenced this pull request Jun 6, 2019

add forgotten changes to the changelog
about fixed issue #398 and PR #1467

remyhaemmerle-da added a commit that referenced this pull request Jun 6, 2019

mergify bot added a commit that referenced this pull request Jun 6, 2019

add forgotten changes to the changelog (#1539)
* add forgotten changes to the changelog
about fixed issue #398 and PR #1467

* Address Beth's comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.