New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add colon (:) to party literal #1467
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabor-aranyossy
approved these changes
May 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as @remyhaemmerle-da confirms that @bitonic is aware of this change.
remyhaemmerle-da
force-pushed
the
spec-cleanup
branch
2 times, most recently
from
May 31, 2019 14:42
0c60c69
to
572031f
Compare
Are we retroactively changing the DAML-LF spec here? |
remyhaemmerle-da
force-pushed
the
spec-cleanup
branch
from
June 3, 2019 08:25
572031f
to
ea895bb
Compare
S11001001
approved these changes
Jun 3, 2019
remyhaemmerle-da
force-pushed
the
spec-cleanup
branch
from
June 4, 2019 07:40
ea895bb
to
382475d
Compare
bitonic
approved these changes
Jun 4, 2019
remyhaemmerle-da
force-pushed
the
spec-cleanup
branch
from
June 4, 2019 13:47
382475d
to
5028c2f
Compare
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add colon to party literal. We also do some minor cleanup in the specification.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.