Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create-daml-app: make tests pass on m1 #15031

Merged
merged 1 commit into from
Sep 23, 2022
Merged

create-daml-app: make tests pass on m1 #15031

merged 1 commit into from
Sep 23, 2022

Commits on Sep 23, 2022

  1. create-daml-app: make tests pass on m1 

    This is very much a "just make it work" type of patch. The main issues
were:

- A bunch of type errors in the `index.test.ts` file when opened in VS
  Code. I'm not sure how it happened, but it's possible I'm just using a
  more recent TS compiler than whoever edited this last.
- `localhost`, on my machine at least, resolves to `::1`, and therefore
  the connections were just not established. I've opted for replacing
  `localhost` with explicit `127.0.0.1`.
- `npm-cli.js` was not an executable in my `PATH`.

Those tests are obviously not tested by CI, so please review carefully /
test this on your own machine before approving.

CHANGELOG_BEGIN
CHANGELOG_END
    @garyverhaegen-da
    garyverhaegen-da committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    ae6c16c View commit details
    Browse the repository at this point in the history