New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-daml-app: make tests pass on m1 #15031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
garyverhaegen-da
requested review from
remyhaemmerle-da and
ray-roestenburg-da
as code owners
September 19, 2022 15:31
garyverhaegen-da
force-pushed
the
fix-gsg-tests
branch
from
September 22, 2022 13:46
fd3a3da
to
5e21231
Compare
remyhaemmerle-da
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look reasonable.
Additional testing steps taken:
|
garyverhaegen-da
force-pushed
the
fix-gsg-tests
branch
from
September 22, 2022 20:08
783225c
to
3856be3
Compare
This is very much a "just make it work" type of patch. The main issues were: - A bunch of type errors in the `index.test.ts` file when opened in VS Code. I'm not sure how it happened, but it's possible I'm just using a more recent TS compiler than whoever edited this last. - `localhost`, on my machine at least, resolves to `::1`, and therefore the connections were just not established. I've opted for replacing `localhost` with explicit `127.0.0.1`. - `npm-cli.js` was not an executable in my `PATH`. Those tests are obviously not tested by CI, so please review carefully / test this on your own machine before approving. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
force-pushed
the
fix-gsg-tests
branch
from
September 23, 2022 01:47
aed4688
to
ae6c16c
Compare
garyverhaegen-da
added a commit
that referenced
this pull request
Sep 23, 2022
This is very much a "just make it work" type of patch. The main issues were: - A bunch of type errors in the `index.test.ts` file when opened in VS Code. I'm not sure how it happened, but it's possible I'm just using a more recent TS compiler than whoever edited this last. - `localhost`, on my machine at least, resolves to `::1`, and therefore the connections were just not established. I've opted for replacing `localhost` with explicit `127.0.0.1`. - `npm-cli.js` was not an executable in my `PATH`, and won't be for most users, but `npm` is not on our testing infrastructure's `PATH`. Those tests are obviously not tested by CI, so please review carefully / test this on your own machine before approving. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
added a commit
that referenced
this pull request
Sep 23, 2022
This is very much a "just make it work" type of patch. The main issues were: - A bunch of type errors in the `index.test.ts` file when opened in VS Code. I'm not sure how it happened, but it's possible I'm just using a more recent TS compiler than whoever edited this last. - `localhost`, on my machine at least, resolves to `::1`, and therefore the connections were just not established. I've opted for replacing `localhost` with explicit `127.0.0.1`. - `npm-cli.js` was not an executable in my `PATH`, and won't be for most users, but `npm` is not on our testing infrastructure's `PATH`. Those tests are obviously not tested by CI, so please review carefully / test this on your own machine before approving. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
added a commit
that referenced
this pull request
Sep 27, 2022
This is very much a "just make it work" type of patch. The main issues were: - A bunch of type errors in the `index.test.ts` file when opened in VS Code. I'm not sure how it happened, but it's possible I'm just using a more recent TS compiler than whoever edited this last. - `localhost`, on my machine at least, resolves to `::1`, and therefore the connections were just not established. I've opted for replacing `localhost` with explicit `127.0.0.1`. - `npm-cli.js` was not an executable in my `PATH`, and won't be for most users, but `npm` is not on our testing infrastructure's `PATH`. Those tests are obviously not tested by CI, so please review carefully / test this on your own machine before approving. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
added a commit
that referenced
this pull request
Sep 27, 2022
This is very much a "just make it work" type of patch. The main issues were: - A bunch of type errors in the `index.test.ts` file when opened in VS Code. I'm not sure how it happened, but it's possible I'm just using a more recent TS compiler than whoever edited this last. - `localhost`, on my machine at least, resolves to `::1`, and therefore the connections were just not established. I've opted for replacing `localhost` with explicit `127.0.0.1`. - `npm-cli.js` was not an executable in my `PATH`, and won't be for most users, but `npm` is not on our testing infrastructure's `PATH`. Those tests are obviously not tested by CI, so please review carefully / test this on your own machine before approving. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
added a commit
that referenced
this pull request
Sep 27, 2022
This is very much a "just make it work" type of patch. The main issues were: - A bunch of type errors in the `index.test.ts` file when opened in VS Code. I'm not sure how it happened, but it's possible I'm just using a more recent TS compiler than whoever edited this last. - `localhost`, on my machine at least, resolves to `::1`, and therefore the connections were just not established. I've opted for replacing `localhost` with explicit `127.0.0.1`. - `npm-cli.js` was not an executable in my `PATH`, and won't be for most users, but `npm` is not on our testing infrastructure's `PATH`. Those tests are obviously not tested by CI, so please review carefully / test this on your own machine before approving. CHANGELOG_BEGIN CHANGELOG_END
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much a "just make it work" type of patch. The main issues were:
index.test.ts
file when opened in VS Code. I'm not sure how it happened, but it's possible I'm just using a more recent TS compiler than whoever edited this last.localhost
, on my machine at least, resolves to::1
, and therefore the connections were just not established. I've opted for replacinglocalhost
with explicit127.0.0.1
.npm-cli.js
was not an executable in myPATH
.Those tests are obviously not tested by CI, so please review carefully / test this on your own machine before approving.
CHANGELOG_BEGIN
CHANGELOG_END