[2.3.6] create-daml-app: make tests pass on m1 #15076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyverhaegen-da
requested review from
remyhaemmerle-da and
ray-roestenburg-da
as code owners
|
This is only changing text in the docs and an internal test, so should be safe, and I do believe we want to have correct docs on the live website before 2.5.0. |
garyverhaegen-da
changed the title
remyhaemmerle-da
approved these changes
Sep 23, 2022
ray-roestenburg-da
approved these changes
Sep 23, 2022
This is very much a "just make it work" type of patch. The main issues were: - A bunch of type errors in the `index.test.ts` file when opened in VS Code. I'm not sure how it happened, but it's possible I'm just using a more recent TS compiler than whoever edited this last. - `localhost`, on my machine at least, resolves to `::1`, and therefore the connections were just not established. I've opted for replacing `localhost` with explicit `127.0.0.1`. - `npm-cli.js` was not an executable in my `PATH`, and won't be for most users, but `npm` is not on our testing infrastructure's `PATH`. Those tests are obviously not tested by CI, so please review carefully / test this on your own machine before approving. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
force-pushed
the
fix-gsg-tests-2.3.6
branch
from
d1d9a11
to
5e26b57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.