[BACKPORT #15422] gsg test: pin puppeteer #15490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyverhaegen-da
requested review from
stefanobaghino-da,
a team and
hrischuk-da
as code owners
|
This is a backport of #15422. |
garyverhaegen-da
changed the title
Somehow our setup doesn't work with puppeteer 19+. CHANGELOG_BEGIN - GSG: Several TypeScript warnings have been fixed in the final "Testing Your Web App" section of the Getting Started Guide. The `create-daml-app` template includes an updated `config.ts` file, and the documentation page as been updated to pin the `puppeteer` version to a known-working one and tweak the `index.test.ts` file. CHANGELOG_END
garyverhaegen-da
force-pushed
the
pin-puppeteer-2.4.x
branch
from
807d331
to
18ce3e3
Compare
stefanobaghino-da
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 2.4.1 will include #15031, we might as well go all the way to a working gsg test page for the 2.4.1 docs.