Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide DA.Internal.LF.coerceContractId #16180

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Conversation

akrmn
Copy link
Contributor

@akrmn akrmn commented Jan 27, 2023

No description provided.

@akrmn akrmn force-pushed the akrmn/unhide-coerce-contract-id branch from 7c03b81 to 69772ea Compare January 27, 2023 11:24
-- but not really something that we want to expose to users.
-- | Used to convert the type index of a `ContractId`, since they are just
-- pointers. Note that subsequent fetches and exercises might fail if the
-- template of the contract on the ledger doesn't match.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add a recommendation to use more type-safe function, like fromInterface, toInterface , fromRequiringInterface

Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞

@basvangijzel-DA
Copy link
Contributor

What is the context for adding this back?

@akrmn
Copy link
Contributor Author

akrmn commented Jan 27, 2023

What is the context for adding this back?

this is not really adding it back, just adding it to the docs. The reason is that we were using it anyways, specifically in the code generated by daml ledger export.

@akrmn akrmn merged commit e9963e8 into main Jan 27, 2023
@akrmn akrmn deleted the akrmn/unhide-coerce-contract-id branch January 27, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants