Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Script] move test_daml_script_test_runner from sandbox to canton #16616

Merged
merged 2 commits into from
Mar 31, 2023
Merged

[Script] move test_daml_script_test_runner from sandbox to canton #16616

merged 2 commits into from
Mar 31, 2023

Conversation

remyhaemmerle-da
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da commented Mar 28, 2023 •
edited
Loading

We migrate the test from bash to scala to take advantage of the CantonFixture that starts canton "magically"

@remyhaemmerle-da remyhaemmerle-da requested a review from a team March 28, 2023 12:57
@remyhaemmerle-da remyhaemmerle-da mentioned this pull request Mar 28, 2023
Closed
@remyhaemmerle-da remyhaemmerle-da force-pushed the remy-trigger-tests branch 7 times, most recently from 7be72b5 to bb4791e Compare March 30, 2023 09:08
nickchapman-da
nickchapman-da approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@nickchapman-da nickchapman-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuel-williams-da
Copy link
Contributor

Oh - what ended up being the problem with windows tests?

@remyhaemmerle-da
Copy link
Collaborator Author

Oh - what ended up being the problem with windows tests?

Mainly:

  • Handling file paths is much more fragile
  • new lines are different

@remyhaemmerle-da remyhaemmerle-da merged commit c20fc05 into main Mar 31, 2023
@remyhaemmerle-da remyhaemmerle-da deleted the remy-trigger-tests branch March 31, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickchapman-da nickchapman-da nickchapman-da approved these changes

@samuel-williams-da samuel-williams-da samuel-williams-da approved these changes

@garyverhaegen-da garyverhaegen-da Awaiting requested review from garyverhaegen-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@remyhaemmerle-da @samuel-williams-da @nickchapman-da