Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing closure for checkpointQueue in SqlLedger #1702

Merged
merged 2 commits into from
Jun 17, 2019

Conversation

gabor-aranyossy
Copy link
Contributor

The checkpointQueue in SqlLedger was not closed properly causing annoying errors like: ERROR c.d.p.s.stores.ledger.sql.SqlLedger - checkpoint queue has been closed with a failure! akka.stream.StreamDetachedException: Stream is terminated. Materialized value is detached. when stopping the Sandbox.

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@gabor-aranyossy gabor-aranyossy added the component/ledger Sandbox and Ledger API label Jun 17, 2019
@gabor-aranyossy
Copy link
Contributor Author

gabor-aranyossy commented Jun 17, 2019

@gerolf-da this was clearly an issue, but I doubt it's the actual cause for the perf-test timeouts in CI.

@gabor-aranyossy gabor-aranyossy merged commit 7b7b7d9 into master Jun 17, 2019
@gabor-aranyossy gabor-aranyossy deleted the perf-timeout branch June 17, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ledger Sandbox and Ledger API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants