Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing closure for checkpointQueue in SqlLedger #1702

Merged
merged 2 commits into from Jun 17, 2019

Conversation

Projects
None yet
2 participants
@gabor-aranyossy
Copy link
Contributor

commented Jun 17, 2019

The checkpointQueue in SqlLedger was not closed properly causing annoying errors like: ERROR c.d.p.s.stores.ledger.sql.SqlLedger - checkpoint queue has been closed with a failure! akka.stream.StreamDetachedException: Stream is terminated. Materialized value is detached. when stopping the Sandbox.

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@gabor-aranyossy

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

@gerolf-da this was clearly an issue, but I doubt it's the actual cause for the perf-test timeouts in CI.

@gabor-aranyossy gabor-aranyossy force-pushed the perf-timeout branch from f808ef1 to a5d555d Jun 17, 2019

@gabor-aranyossy gabor-aranyossy requested a review from bethaitman as a code owner Jun 17, 2019

@gabor-aranyossy gabor-aranyossy merged commit 7b7b7d9 into master Jun 17, 2019

7 checks passed

Summary 2 potential rules
Details
digital-asset.daml Build #20190617.12 succeeded
Details
digital-asset.daml (Linux) Linux succeeded
Details
digital-asset.daml (Windows) Windows succeeded
Details
digital-asset.daml (macOS) macOS succeeded
Details
digital-asset.daml (perf) perf succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@gabor-aranyossy gabor-aranyossy deleted the perf-timeout branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.