A couple of improvements to the experience developing hie-core itself #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ostic It's useful when looking at the hie-core command-line output to see where a problem is coming from.
cocreature
approved these changes
Sep 8, 2019
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ndmitchell
approved these changes
Sep 8, 2019
hsenag
added a commit
to hsenag/daml
that referenced
this pull request
Sep 13, 2019
…digital-asset#2812) * Put information about the compiler pass in the _source field of Diagnostic It's useful when looking at the hie-core command-line output to see where a problem is coming from. * include test code in hie-core's own cradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of changes I found useful when making changes to hie-core (to support .hs-boot files,
I'll send a separate PR when that's ready).
Including the compiler pass in the diagnostic source helped me understand which bit of code
needed changing.
Since the hie.yaml file already includes both the library and the exe, it makes sense to include the tests too.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.