leger-api: add GenMap support #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
requested review from
SamirTalwar,
gerolf-da and
stefanobaghino-da
remyhaemmerle-da
requested review from
leo-da,
nickchapman-da,
rautenrieth-da and
S11001001
as code owners
|
Should I add a line in the release notes ? |
gerolf-da
approved these changes
Nov 18, 2019
...ledger-api-common/src/main/scala/com/digitalasset/ledger/api/validation/ValueValidator.scala
Show resolved
Hide resolved
IMO it's best to leave |
I would like, but this change will break scala/haskell code (with a non exhaustive pattern matching) that relies on the code generated from the proto definition. |
remyhaemmerle-da
force-pushed
the
ledger-genmap
branch
from
2c00c45
to
8372e30
Compare
remyhaemmerle-da
force-pushed
the
ledger-genmap
branch
from
8ce247f
to
6986f67
Compare
bame-da
pushed a commit
that referenced
this pull request
Nov 19, 2019
* leger-api: add GenMap support * cosmetic * Address Gerolf's comment * add a point in the release notes * Address Fran's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR advances #2256.
It adds support of GenMap to the ledger API.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.