Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing genmap functions #3807

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Implement missing genmap functions #3807

merged 1 commit into from
Dec 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 10, 2019

This PR advances #2256. These were the missing pieces of the Haskell implementation of GenMap.

@ghost ghost requested a review from hurryabit as a code owner December 10, 2019 16:03
@ghost ghost changed the title Implement missing genmap fns Implement missing genmap functions Dec 10, 2019
cocreature
cocreature approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

remyhaemmerle-da
remyhaemmerle-da approved these changes Dec 11, 2019
View reviewed changes
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.

@ghost ghost closed this Dec 11, 2019
@ghost ghost reopened this Dec 11, 2019
@ghost ghost added the automerge label Dec 11, 2019
@mergify mergify bot merged commit 08ee42f into master Dec 11, 2019
@mergify mergify bot deleted the genmap branch December 11, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickchapman-da nickchapman-da Awaiting requested review from nickchapman-da

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @remyhaemmerle-da