Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAML-LF add support for generic comparison in archive #4983

Merged
merged 2 commits into from
Mar 13, 2020

Conversation

remyhaemmerle-da
Copy link
Collaborator

In this PR we add support for generic comparison function in LF archive.

This advances #2256

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@remyhaemmerle-da remyhaemmerle-da added this to the Maintenance milestone Mar 13, 2020
@remyhaemmerle-da remyhaemmerle-da force-pushed the lf-gen-comparison branch 2 times, most recently from d75b85c to 9d70440 Compare March 13, 2020 10:11
@remyhaemmerle-da remyhaemmerle-da changed the title Lf gen comparison DAML-LF add support for generic comparison in archive Mar 13, 2020
CHANGELOG_BEGIN
CHANGELOG_END
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple modifications. Thanks!

Co-Authored-By: associahedron <231829+associahedron@users.noreply.github.com>
@remyhaemmerle-da remyhaemmerle-da merged commit c76e0bc into master Mar 13, 2020
@remyhaemmerle-da remyhaemmerle-da deleted the lf-gen-comparison branch March 13, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant