-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use 2.13-style collections library syntax in json-api #6075
Conversation
CHANGELOG_BEGIN CHANGELOG_END
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but we need to make sure the changes do not affect performance, we touched interpreter and data.transaction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Noice. |
As discussed, these changes lay outside the critical path in question. |
…-2.13-esque-colls
…-2.13-esque-colls
Preparing for Scala 2.13 by removing some constructs no longer present there, replacing them with existing portable constructs or those provided by scala-collection-compat, as @leo-da suggested. Currently included:
breakOut
, we use.view.op(...).toX
, with variations:view
causes anAny
warning, we useiterator
insteaditerator
insteadtoX
, we useto(X)
instead, by importingscala.collection.compat._
to[X]
, we usetoX
orto(X)
, depending on what is availableto(List)
Those of the changes above that didn't require
scala-collection-compat
have also been made in thedaml-lf
tree.Fixes #5874.
Pull Request Checklist
CHANGELOG_BEGIN
andCHANGELOG_END
tagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.