Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration guide for new assistant #768

Merged
merged 6 commits into from May 6, 2019

Conversation

Projects
None yet
3 participants
@bethaitman
Copy link
Contributor

commented Apr 29, 2019

Have not added release note yet.

I'd particularly appreciate:

  • suggestions for the start of the doc, explaining the good things about the new assistant
  • a thorough check of the tables, to make sure I've got the migration details correct
@cocreature
Copy link
Contributor

left a comment

LGTM, thank you!

Show resolved Hide resolved docs/source/support/new-assistant.rst Outdated
Show resolved Hide resolved docs/source/support/new-assistant.rst Outdated

@associahedron associahedron force-pushed the migration-to-new-assistant branch 3 times, most recently from 0a014aa to dc7bb4e Apr 30, 2019

@bethaitman

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

I've made my final changes: I now consider this done enough for a first go (in that, this is as good as it'll get without user feedback, so that's what we should look for next.).

@bethaitman bethaitman added the automerge label May 6, 2019

@cocreature cocreature force-pushed the migration-to-new-assistant branch 3 times, most recently from c23d120 to dbea50f May 6, 2019

@cocreature cocreature force-pushed the migration-to-new-assistant branch from dbea50f to 935af2e May 6, 2019

@mergify mergify bot merged commit d77384b into master May 6, 2019

8 checks passed

Rule: automatic merge marked PRs on CI success and review (merge) The pull request has been merged automatically
Details
Summary 1 rule matches
Details
digital-asset.daml Build #20190506.79 succeeded
Details
digital-asset.daml (Linux) Linux succeeded
Details
digital-asset.daml (Windows) Windows succeeded
Details
digital-asset.daml (macOS) macOS succeeded
Details
digital-asset.daml (perf) perf succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@mergify mergify bot deleted the migration-to-new-assistant branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.