Comment out windows jobs #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI fails on windows due to commercialhaskell/stack#5732
|
No need for a rebase, running CI again should be enough. |
garyverhaegen-da
approved these changes
May 5, 2022
sofiafaro-da
approved these changes
May 5, 2022
|
For future audits, CI results on #363 evidence that this is a "rest of the internet broke" kind of failure, not one introduced in any of @shayne-fletcher's changes (in case there was any doubt). One could argue we should look into pinning our dependencies, but given this is the fist time this has been an issue (that I am aware of), I don't think that's a high priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI fails on windows due to commercialhaskell/stack#5732
@shayne-fletcher,
could you please rebase your branch onI'll rerun CI on your PR once this is mergedmasteronce this is merged? Alternatively, you could also cherry-pick the single commit here.