Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate scan results #5

Closed
dietb opened this issue Jan 27, 2021 · 0 comments
Closed

Deduplicate scan results #5

dietb opened this issue Jan 27, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dietb
Copy link
Contributor

dietb commented Jan 27, 2021

When performing a scan, devices tend to show up more than once. De-duplicate the list before displaying it.

vector-bluetooth/ble/conn/scan.go

Line 46 in e09d697

for k, v := range c.scanresults {

In addition, the type returned from scan shouldn't be passed through from the bleconn package.

vector-bluetooth/ble/passthroughfuncs.go

Line 6 in e09d697

func (v *VectorBLE) Scan() (*conn.ScanResponse, error) {

@dietb dietb added good first issue Good for newcomers enhancement New feature or request labels Jan 27, 2021
dietb added a commit that referenced this issue Jan 27, 2021
@dietb
fixes issue #5 - only one duplicate device is displayed and the type …
c0058d4 
…is abstracted
@dietb dietb closed this as completed Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dietb