Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage special folders (forbidden, shortcuts) #404

Merged
merged 9 commits into from
Mar 4, 2020

Conversation

sparkhi
Copy link
Collaborator

@sparkhi sparkhi commented Feb 27, 2020

[Update Jeremie]

Issues

#395
#406

Solution

  • Added a validation to make sure non - fs folders like 'Libraries' onwindows cannot be added
  • manage forbidden files and folders: prevent breaking + show as forbidden in GUI

Acceptance Test

NOTE: The testing can only be done on Windows OS for this fix, other OSs should not see any change.

  1. Open Droid GUI
  2. Create a new profile
  3. Click on the 'add' button to bring up file chooser dialog
  4. Pick one of the Windows 'virtual collection' folder (e.g. Libraries, Documents) which does not map directly to file system
  5. You should see an error message informing you that the folder is not allowed.
  6. If there is more than one non-file-system folder picked in step DROID Export URI is malformed in CSV output #4 above, all such folder names should appear in the error
  7. If there is a combination of non-file-system folder and a file-system-folder, the error message should inform only about the non file-system folder
  8. If all folders picked in step DROID Export URI is malformed in CSV output #4 are valid file-system folders, they should all be added to the profiling dialog.

@sparkhi
Copy link
Collaborator Author

sparkhi commented Feb 27, 2020

Acceptance Test

NOTE: The testing can only be done on Windows OS for this fix, other OSs should not see any change.

  1. Open Droid GUI
  2. Create a new profile
  3. Click on the 'add' button to bring up file chooser dialog
  4. Pick one of the Windows 'virtual collection' folder (e.g. Libraries, Documents) which does not map directly to file system
  5. You should see an error message informing you that the folder is not allowed.
  6. If there is more than one non-file-system folder picked in step DROID Export URI is malformed in CSV output #4 above, all such folder names should appear in the error
  7. If there is a combination of non-file-system folder and a file-system-folder, the error message should inform only about the non file-system folder
  8. If all folders picked in step DROID Export URI is malformed in CSV output #4 are valid file-system folders, they should all be added to the profiling dialog.

@jcharlet jcharlet added the bug label Mar 2, 2020
@jcharlet jcharlet added this to the 6.5 milestone Mar 2, 2020
@jcharlet jcharlet added this to In progress in DROID Kanban board 6.5 via automation Mar 2, 2020
@jcharlet
Copy link
Contributor

jcharlet commented Mar 2, 2020

fix #395

@jcharlet
Copy link
Contributor

jcharlet commented Mar 2, 2020

works on libraries and similar folders, but crashes on forbidden folders.
unrelated to this PR, problem already there on 6.4 on Linux. new issue raised

@jcharlet jcharlet changed the title Added a validation to make sure non - fs folders like 'Libraries' on … Manage special folders (forbidden, shortcuts) Mar 2, 2020
@jcharlet
Copy link
Contributor

jcharlet commented Mar 2, 2020

as discussed with Saurab, this PR will fix as well #406

Copy link
Contributor

@jcharlet jcharlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly pair programming, implemented and reviewed together

DROID Kanban board 6.5 automation moved this from In progress to Reviewer approved Mar 4, 2020
@jcharlet jcharlet merged commit 6fe80c8 into master Mar 4, 2020
DROID Kanban board 6.5 automation moved this from Reviewer approved to Done Mar 4, 2020
@sparkhi sparkhi deleted the windows-non-fs-folder-395 branch April 3, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants