Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update threatexpert_hash2domain.py #33

Merged
merged 1 commit into from
Sep 15, 2013

Conversation

deresz
Copy link
Contributor

@deresz deresz commented Sep 15, 2013

ThreatExpert site was returning results that was not reflected in the file (maybe due to a recent change) - added one try/except

ThreatExpert site was returning results that was not reflected in the file (maybe due to a recent change) - added one try/except
@digital4rensics
Copy link
Owner

Thanks for the fix. Are you able to confirm that the existing parsing code for the 'single' variable also works for the new try/except block? If so, I'll merge right off.

@deresz
Copy link
Contributor Author

deresz commented Sep 15, 2013

No prob. It seems to work fine. I have tried it with several samples,
for example:
http://www.threatexpert.com/report.aspx?md5=539885ae4411f9f17255694bd7b60a59

A.

On 9/15/2013 8:07 PM, digital4rensics wrote:

Thanks for the fix. Are you able to confirm that the existing parsing
code for the 'single' variable also works for the new try/except
block? If so, I'll merge right off.


Reply to this email directly or view it on GitHub
#33 (comment).

digital4rensics added a commit that referenced this pull request Sep 15, 2013
Update threatexpert_hash2domain.py
@digital4rensics digital4rensics merged commit 9b7f600 into digital4rensics:master Sep 15, 2013
@digital4rensics
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants