Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of MultiKey #2

Closed
HelgeKrueger opened this issue Jun 9, 2023 · 3 comments
Closed

Status of MultiKey #2

HelgeKrueger opened this issue Jun 9, 2023 · 3 comments

Comments

@HelgeKrueger
Copy link
Contributor

I discovered this repository through the usage here. See also the discussion here.

The @context implies that a MultiKey object can only have the properties: "controller", "publicKeyMultibase", "secretKeyMultibase" and "revoked" (in addition to "@id" and "@type" which any json-ld object can have). I'm wondering about these choices:

  • As far as I can see publishing a document with "secretKeyMultibase" should never happen. The only exception I can imagine is test data, and even then I'm not sure it's the best solution.
  • If I want to use a MultiKey object in the context of verification, see .e.g. here, I want to specify how long the key will stay valid, i.e. the property expires, and not if the key has been revoked.

So my question is: How final is this document as a definition of https://w3id.org/security#Multikey?

@dmitrizagidulin
Copy link

dmitrizagidulin commented Jul 7, 2023

Hi @HelgeKrueger! Thank you for raising these questions.

Re the MultiKey expires field - I think that's a great idea, and having checked with @msporny and other stakeholders, there seems to be no objections. So, the next steps would be to add it to this repo's context, and probably also add it to the various Data Integrity specs (like the eddsa multikey examples you linked to). Would you feel comfortable making the PRs?

@HelgeKrueger
Copy link
Contributor Author

I can prepare a PR, but it might take me a week or two.

HelgeKrueger added a commit to HelgeKrueger/multikey-context that referenced this issue Jul 19, 2023
@dmitrizagidulin
Copy link

This issue can be closed once PR #3 is merged.

dlongley pushed a commit that referenced this issue Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants