Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load from HTML #108

Merged
merged 4 commits into from
Apr 13, 2020
Merged

Load from HTML #108

merged 4 commits into from
Apr 13, 2020

Conversation

gkellogg
Copy link
Collaborator

  • Use lxml.html to load HTML and parse in load_html.
    • For HTML, the API base option can be updated from base element.

Note this is a PRI into 1.1-expansion.

@gkellogg
Copy link
Collaborator Author

Note the 3.4 failure:

Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-phouehag/lxml/

Do we want to bump the minimum version to 3.5 or figure out how to do this conditionally?

@dlongley
Copy link
Member

dlongley commented Apr 6, 2020

@davidlehn, please review.

@davidlehn davidlehn merged commit 5d2c82d into 1.1-expansion Apr 13, 2020
@davidlehn davidlehn deleted the html branch April 13, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants