Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_document: Lower priority of HTML inputs #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cid-chan
Copy link

This fixes a bug with activitypub related documents: The schema "https://www.w3.org/ns/activitystreams" renders the spec if "application/json" has a lower prioritisation than "text/html".

This fixes a bug with activitypub related documents: The schema "https://www.w3.org/ns/activitystreams" renders the spec if "application/json" has a lower prioritisation than "text/html".
@@ -6568,10 +6568,10 @@ def load_document(url,
:return: True if the value is an absolute IRI, False if not.
"""
headers = {
'Accept': 'application/ld+json, application/json;q=0.5'
'Accept': 'application/ld+json, application/json;q=0.8'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We define headers['Accept'] here…

}
# FIXME: only if html5lib loaded?
headers['Accept'] = headers['Accept'] + ', text/html;q=0.8, application/xhtml+xml;q=0.8'
headers['Accept'] = headers['Accept'] + ', text/html;q=0.5, application/xhtml+xml;q=0.5'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…and we modify that value here.

  • Would it be possible to specify the final value right away?
  • Probably a comment explaining what the magic 0.5 means would also be helpful to future readers.

@BigBlueHat
Copy link
Contributor

This looks fine generally, but lets get some tests written for it. @anatoly-scherbakov would you be up for doing that to test out the "local tests" you were sad we didn't have here?

@BigBlueHat BigBlueHat added this to the v2.0.4 milestone Feb 5, 2024
@BigBlueHat BigBlueHat modified the milestones: v2.0.4, v2.0.5 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants